Increase test coverage for managed cluster webhooks #1339
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/XL
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| ) | ||
|
|
||
| var ( | ||
| vV1_27_1 = "v1.27.1" |
There was a problem hiding this comment.
This should be hardcoded? can we avoid that?
There was a problem hiding this comment.
This is simply used as a valid version placeholder but the value itself is not relevant. I'd say we won't need to update this in the foreseeable future, so it won't hurt that it is hard-coded. What do you think?
Signed-off-by: Carlos Salas <[email protected]>
Signed-off-by: Carlos Salas <[email protected]>
Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
force-pushed
the
gcpmanaged-improve-test-coverage
branch
from
af55bae to
3752077
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, salasberryfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
3 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
As we already started discussions on promoting managed clusters out of experimental (refer to this issue), this PR improves test coverage of control plane, cluster and machine pool webhooks. Some existing machine pool test cases have been formatted to align with the newly added scenarios (which are similar to the ones used by other providers).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
TODOs:
Release note: